aprantl added inline comments.
================
Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:3736
if (is_debug) {
switch (nlist.n_type) {
----------------
because of the early exit above — isn't this either always true or always false?
================
Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:4477
+ // comment for an explanation why.
+ std::vector<struct nlist_64> nlists;
+ for (; nlist_idx < symtab_load_command.nsyms; ++nlist_idx) {
----------------
reserve symtab_load_command.nsyms elements?
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68536/new/
https://reviews.llvm.org/D68536
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
