xiaobai added a reviewer: JDevlieghere.
xiaobai added a comment.

@JDevlieghere has been touching similar things today. You should coordinate 
with him on this change.



================
Comment at: lit/CMakeLists.txt:64
   )
+if(NOT LLDB_BUILT_STANDALONE)
+  list(APPEND LLDB_TEST_DEPS llvm-strip)
----------------
why not `if(TARGET llvm-strip)`? I think that expresses the intent more cleanly 
(and conforms to the existing pattern).


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68614/new/

https://reviews.llvm.org/D68614



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to