labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
looks good to me
================
Comment at: packages/Python/lldbsuite/test/lang/c/enum_types/TestEnumTypes.py:44
+ # Test that an enum that doesn't match the heuristic we use in
+ # ClabgASTContext::DumpEnumValue, gets printed as a raw integer.
+ self.expect("fr var omega", DATA_TYPES_DISPLAYED_CORRECTLY,
----------------
s/clabg/clang
================
Comment at: source/Symbol/ClangASTContext.cpp:9428
+ // `enum {A, B, ALL = A|B }` we visit ALL first. Use a stable sort so that
+ // A | C where A < C is displayed in this order.
+ std::stable_sort(values.begin(), values.end(), [](const auto &a, const auto
&b) {
----------------
I guess this really means "where A is declared before C", because A can be
numerically higher even if it's declared first.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67520/new/
https://reviews.llvm.org/D67520
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
