labath added a comment. Even if we ignore the windows parts, there's still a lot of duplication here. The bits that extract a "complete" line from the buffer look like they could be factored into a separate function (`Optional<string> GetCompleteLineFromCache(...)` ?). It would not hurt to split the parts that read from a FILE and the parts reading from the lldb_private::File into separate functions too... Other than that, the functionality seems fine to me...
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68622/new/ https://reviews.llvm.org/D68622 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
