labath added a comment. In D68606#1699197 <https://reviews.llvm.org/D68606#1699197>, @thopre wrote:
> Shouldn't the CMake target remain check-lldb-unit to be consistant with > check-llvm-unit/check-clang-unit etc.? In D68606#1699219 <https://reviews.llvm.org/D68606#1699219>, @mstorsjo wrote: > > and finally rename `lit` to `tests` > > Shouldn't that be `test`, to be consistent with llvm/lld/clang and others? +1 to both of these. More generally, there are other things here which are not consistent with llvm layouts, and I am wondering how much should try to be compatible with that. On one hand, consistency is good, but on the other, llvm does not have _three_ kinds of tests to worry about. For instance, `test/Unit` *is* consistent with the llvm location of unit tests, and by extension `test/Suite` could be considered the "right place" for non-filecheck tests too (though maybe it shouldn't be called "Suite"). Speaking of that, I am not completely sure about the name "filecheck" either -- technically this should be "shtest" as that is their main distinguishing feature, though that may end up being too pedantic. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68606/new/ https://reviews.llvm.org/D68606 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
