MaskRay added a comment.

This was probably due to:

    Expected(Error Err)
        : HasError(true)
  #if LLVM_ENABLE_ABI_BREAKING_CHECKS
          // Expected is unchecked upon construction in Debug builds.
          , Unchecked(true)
  #endif
    {
      assert(Err && "Cannot create Expected<T> from Error success value.");
      new (getErrorStorage()) error_type(Err.takePayload());
    }

The member initialization makes the members unchecked 
`m_operation_thread(nullptr)`. Adding something like 
`(void)!m_operation_thread` before assignment to `m_operation_thread` is 
probably better.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68723/new/

https://reviews.llvm.org/D68723



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to