labath added inline comments.
================ Comment at: lldb/packages/Python/lldbsuite/test/python_api/file_handle/TestFileHandle.py:827-835 + self.assertRaises(TypeError, self.debugger.SetOutputFile, None) + self.assertRaises(TypeError, self.debugger.SetOutputFile, "ham sandwich") + self.assertRaises(TypeError, self.debugger.SetOutputFileHandle, "ham sandwich") + self.assertRaises(TypeError, self.debugger.SetInputFile, None) + self.assertRaises(TypeError, self.debugger.SetInputFile, "ham sandwich") + self.assertRaises(TypeError, self.debugger.SetInputFileHandle, "ham sandwich") + self.assertRaises(TypeError, self.debugger.SetErrorFile, None) ---------------- I think these will fail with swig<=3. See my r374322. I personally don't think you need these checks for _every_ api taking accepting a file object, but if you do want to have them, you'll need to account for the differences in swig versions somehow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68856/new/ https://reviews.llvm.org/D68856 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
