clayborg added a comment.

I think it would be nice to have a new member to ProcessInfo like:

  std::string m_bundle_id;

This notion works for MacOS and for Android. When launching on iOS, we need to 
application bundle identifier to do the launching as the install of the app 
registers the app with the OS app launcher and is launched using its bundle 
identifier.

I would like to see the m_executable always contain the path to "app_process" 
binary. Arg0 is currently used when spawning via posix_spawn or fork/exec to 
control the name of the binary that is actually passed on the command line. For 
example you might specify "clang++" as your binary. If we resolved this to a 
binary we would find it resolves to "clang++@ -> clang", but we want to pass in 
clang++ as the arg0 so the compiler knows to  run in C++ mode. So I would like 
Arg0 to be the actual argument that the client would like to be passed to the 
executable. Then m_bundle_id can be used by the platform launching code to 
launch the app. Also, by having m_executable set to "app_process", we can 
create a valid target in LLDB using the ProcessInfo and then launch/attach.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68968/new/

https://reviews.llvm.org/D68968



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to