llunak marked an inline comment as done.
llunak added inline comments.
================
Comment at:
lldb/packages/Python/lldbsuite/test/commands/gui/basicdebug/TestGuiBasicDebug.py:31
+ # which is not necessarily the order on the screen.)
+ self.child.timeout = 2
+ self.child.send("s") # step
----------------
labath wrote:
> What's the reason for that? It'd be best to not mess with the timeout in the
> test, and particularly to not set such a small time out as it will likely
> lead to flakyness on slow/heavily loaded machines.
I added it because writing and debugging the unittest without this was a pain,
but fair enough.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68541/new/
https://reviews.llvm.org/D68541
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
