JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added subscribers: teemperor, abidh, dexonsmith, mehdi_amini. Herald added a project: LLDB.
The API tests have a `.clang-format` file that disables formatting altogether. While this is needed for some tests, it also leads to inconsistency between test files. The shell tests suffer from a similar problem: a test with a source-file extension (`.c`, `.cpp`) will get formatted, potentially breaking up lines and leading to invalid RUN commands. Rather than completely disabling formatting here, I propose to not enforce a line limit instead. That way tests will be consistent, but you can still have long run commands (as is not uncommon in LLVM either) and use breakpoints with patters that extend beyond 80 cols. Repository: rLLDB LLDB https://reviews.llvm.org/D69058 Files: lldb/test/Shell/.clang-format Index: lldb/test/Shell/.clang-format =================================================================== --- /dev/null +++ lldb/test/Shell/.clang-format @@ -0,0 +1,3 @@ +BasedOnStyle: LLVM +# We don't want clang-format to introduce line breaks in RUN commands. +ColumnLimit: 999
Index: lldb/test/Shell/.clang-format =================================================================== --- /dev/null +++ lldb/test/Shell/.clang-format @@ -0,0 +1,3 @@ +BasedOnStyle: LLVM +# We don't want clang-format to introduce line breaks in RUN commands. +ColumnLimit: 999
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
