JosephTremoulet marked an inline comment as done.
JosephTremoulet added inline comments.
================
Comment at: llvm/lib/ObjectYAML/MinidumpYAML.cpp:389
+ for (size_t Index = 0; Index < Exception.MaxParameters; ++Index) {
+ SmallString<16> Name = formatv("Parameter {0}", Index);
+ support::ulittle64_t &Field = Exception.ExceptionInformation[Index];
----------------
JosephTremoulet wrote:
> MaskRay wrote:
> > You may use `("Parameter " + Twine(Index)).str()` to get rid of the
> > "llvm/Support/FormatVariadic.h" dependency.
> Is #including FormatVariadic.h a bad thing? I did it this way to avoid heap
> allocation.
...finally realized that Twine avoids the heap too :). Thanks for the
suggestion, updated.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68657/new/
https://reviews.llvm.org/D68657
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
