mstorsjo added a comment.

In D69031#1713900 <https://reviews.llvm.org/D69031#1713900>, @aprantl wrote:

> Check out  `lldb/test/Shell/helper/toolchain.py`, you probably need to filter 
> out some options for clang_cl specifically.


Yeah, I later found that. The issue is that it's passed to usr_clang in i 
llvm/utils/lit/lit/llvm/config.py, which sets all the provided additional flags 
on both %clang, %clangxx, %clang_cc1 and %clang_cl.

Maybe the additional_flags param needs to be split, into one common for all, 
one for gcc-style driver, one for clang_cl, and maybe also a separate one for 
cc1 (where not all driver level flags may fit either)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69031/new/

https://reviews.llvm.org/D69031



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to