labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.
================
Comment at: lldb/scripts/Python/python-wrapper.swig:226
{
- using namespace lldb_private;
if (python_class_name == NULL || python_class_name[0] == '\0' ||
!session_dictionary_name)
----------------
There are empty lines from this point on in this file. Before they made sense
because they were separating the using directive from the actual code, but now
they've just become useless empty lines at the start of a block. Please delete
them.
================
Comment at:
lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPythonImpl.h:26-27
+using namespace lldb_private::python;
+
namespace lldb_private {
----------------
lawrence_danna wrote:
> labath wrote:
> > No using declarations in headers.
> even an "Impl" header?
Nope. The "impl" here comes from the class name, but this is still a header
like any other. Theoretically you could also put everything declared in this
header into the python namespace, but otoh we have to stop somewhere, and this
patch has gotten quite big already.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69214/new/
https://reviews.llvm.org/D69214
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
