aprantl marked 2 inline comments as done. aprantl added inline comments.
================ Comment at: lldb/source/Host/common/Host.cpp:300 va_end(args); + + // Log to log channel. This allows testcases to grep for log output. ---------------- jingham wrote: > On macOS, SystemLog vsprintf's to stderr. So you probably don't want to put > this out always. Maybe since you don't know where SystemLog is going to > print things, it would be better to only output this if the log channel is > set to verbose. That would still allow you to use it in tests, but wouldn't > introduce any new output in the normal case? Turns out LIBLLDB has no VERBOSE channel, and I can't add one because all 32 bits are already defined as channels. In the end this is probably not too bad — how many users are running with the host log enabled? What do you think about making it either/or? It goes to the syslog by default and to the host log if it is enabled? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70272/new/ https://reviews.llvm.org/D70272 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
