labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land.
================ Comment at: lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.h:74-76 + Status + CopyHardwareWatchpointsFrom(NativeRegisterContextNetBSD &source) + override; ---------------- Are you sure this is the proper formatting here? It seems fairly odd.. ================ Comment at: lldb/source/Plugins/Process/NetBSD/NativeThreadNetBSD.cpp:254-255 + .CopyHardwareWatchpointsFrom( + static_cast<NativeRegisterContextNetBSD &>( + source.GetRegisterContext())); + if (!s.Fail()) { ---------------- I'd probably make a covariant override of `GetRegisterContext` which returns a `NativeRegisterContextNetBSD&`. ================ Comment at: lldb/test/Shell/Watchpoint/netbsd-nouserdbregs.test:5 +# REQUIRES: native && system-netbsd && (target-x86 || target-x86_64) && !dbregs-set +# RUN: %clang %p/Inputs/thread-dbreg.c -pthread -g -o %t.out +# RUN: %lldb -b -o 'settings set interpreter.stop-command-source-on-error false' -s %s %t.out 2>&1 | FileCheck %s ---------------- mgorny wrote: > Note to self: try `%clang_host` as suggested in D70050. So, did you try it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70023/new/ https://reviews.llvm.org/D70023 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits