labath added a comment.

I think you should be able to write a test with a yaml2obj + `lldb-test 
object-file`. That's how the equivalent elf functionality is tested (see 
`test/Shell/ObjectFile/ELF/section-types.yaml`). It won't check that the 
section is actually parsed properly, but I don't think that's needed for the 
kind of fix you're making here.

As for the long if-else cascade, the equivalent elf code was recently 
refactored to use llvm::StringSwitch. Doing the same here would be nice.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70745/new/

https://reviews.llvm.org/D70745



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to