clayborg added inline comments.
================ Comment at: lldb/include/lldb/Utility/FileSpec.h:196 static bool Equal(const FileSpec &a, const FileSpec &b, bool full); ---------------- JDevlieghere wrote: > Why do we still need the `Equal` method? Are there cases where `full` is only > decided at runtime? Would it be worth to update the call sites to use `==` or > `::Match` directly? I think having both `Match` and `Equal` with these > semantics is confusing and will likely reintroduce the things you just > cleaned up. I agree with JDev here. ================ Comment at: lldb/include/lldb/Utility/FileSpec.h:202 + /// pattern matches everything. + static bool Match(const FileSpec &pattern, const FileSpec &file); + ---------------- Maybe rename to "Matches"? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70851/new/ https://reviews.llvm.org/D70851 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
