labath added a comment.

In D70886#1765629 <https://reviews.llvm.org/D70886#1765629>, @aadsm wrote:

> The way phabricator shows the diff is tricky, this change has nothing to do 
> with D70882 <https://reviews.llvm.org/D70882> and stands by itself. The 
> important part here is making the `g_vsc.debugger.SetOutputFileHandle(out, 
> true); g_vsc.debugger.SetErrorFileHandle(out, false);` happen before the 
> debugger creation. Not sure how to create a test for this though since 
> there's no mechanism to give lldb-vscode an initial file to load...


Maybe you could do something similar to LocalLLDBInit.test 
<https://github.com/llvm/llvm-project/blob/master/lldb/test/Shell/Driver/LocalLLDBInit.test>
 ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70886/new/

https://reviews.llvm.org/D70886



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to