labath added a comment.

This patch seems really weird to me... We may be able to work around random 
lldb output in the test this way, but that won't help any other DAP client who 
ends up talking to lldb-vscode (or do they have similar workarounds already?). 
In fact it might make things worse -- right now, I guess this is only an issue 
if the user has a noisy .lldbinit file, but if we start ignoring this, other 
random output can appear in the future.

If having a "clean" stdout is important in lldb-vscode, then I think it would 
be better to *not* merge this patch, and try to fix any places which are 
polluting it instead. Since everything should be using the SBDebuggers notion 
of "stdout", anything which prints to the process stdout directly is a bug...

  rG LLVM Github Monorepo


lldb-commits mailing list

Reply via email to