jingham added a comment.
One comment on a part you didn't change, but left a C++ specific track in the
generic ValueObject code.
================
Comment at: lldb/source/Core/ValueObject.cpp:2056
+ if (parent_had_base_class)
+ s.PutCString("::");
+ s.PutCString(class_name.getValue());
----------------
That's still implicitly C. Other languages (swift) use "." for the same
purposes. If this is really language agnostic we either need a "GetSeparator"
function, or we need s "ComposePath" operation from the language.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69820/new/
https://reviews.llvm.org/D69820
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
