JDevlieghere added a comment. In D72107#1802048 <https://reviews.llvm.org/D72107#1802048>, @xiaobai wrote:
> In D72107#1802029 <https://reviews.llvm.org/D72107#1802029>, @JDevlieghere > wrote: > > > Do you mean forcing `LLDB_ENABLE_PYTHON` to on so that it fails in case the > > logic changes and Python isn't found? > > > Yes, something like that. It looks like the previous expected behavior was > that python was implicitly a required dependency (unless you explicitly > disabled it or were building for android/ios). Making it an optional > dependency means that the buildbots should probably explicitly say that they > want to enable python. You could probably not change buildbot invocations, > but that means that if a buildbot fails to find python then we won't know > until something goes wrong (e.g. A test fails locally on some setup that > passed buildbots because buildbots weren't running python tests). Yup, I've updated the config in 9a3d9b7f <https://reviews.llvm.org/rZORG9a3d9b7fea718eab8cdb1c5e6f9436eacdaf7298> Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72107/new/ https://reviews.llvm.org/D72107 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
