labath added a comment.
This seems like it could be useful. Some random questions inline..
================
Comment at: lldb/test/Shell/lit.cfg.py:42-46
if 'LLDB_CAPTURE_REPRODUCER' in os.environ:
config.environment['LLDB_CAPTURE_REPRODUCER'] = os.environ[
'LLDB_CAPTURE_REPRODUCER']
+if 'LLDB_REPRO_CAPTURE' in os.environ:
+ config.environment['LLDB_REPRO_CAPTURE'] = os.environ['LLDB_REPRO_CAPTURE']
----------------
The difference between these two is super-unclear. Any chance to unify them?
================
Comment at: lldb/tools/lldb-repro/lldb-repro.cpp:23
+
+unsigned ComputerHash(StringRef args, StringRef cwd) {
+ const unsigned hash = djbHash(cwd);
----------------
Is the `r` in the name intentional?
================
Comment at: lldb/tools/lldb-repro/lldb-repro.cpp:63
+ args.push_back(repro_dir.c_str());
+ args.push_back("--reproducer-auto-generate");
+
----------------
I am wondering if this shouldn't even be the default behavior. If I already
passed `--capture` to lldb then it does not seem unreasonable to always write
it out when lldb exits (we already do it after a crash, right?)
================
Comment at: lldb/tools/lldb-repro/lldb-repro.h.cmake:12
+
+#cmakedefine LLDB_TEST_EXECUTABLE "${LLDB_TEST_EXECUTABLE}"
+
----------------
Are you sure this will work fine with multi-config generators? You might be
better off just relying on the fact that the lldb executable will sit right
next to this binary...
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72823/new/
https://reviews.llvm.org/D72823
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
