labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
Yes, that's looks pretty much like it, but it seems you uploaded the diff incorrectly -- it looks like its based on the previous version of your patch and not master (you should always upload the full set of changes not just the recent additions). Also, when I asked for an ArrayRef, I forgot that you are sorting the thing -- a vector does seem reasonable in that case (sorry). Do you have commit access? If not, I can land this for you (as soon as I get the correct diff). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72909/new/ https://reviews.llvm.org/D72909 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
