labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
Looks great, modulo the inline comment. ================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3987-4008 + DWARFASTParser *dwarf_ast = GetDWARFParser(*die.GetCU()); + if (dwarf_ast) + return dwarf_ast->GetDeclForUIDFromDWARF(die); + else + return CompilerDecl(); +} + ---------------- [[ http://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return | Don't use else after return ]]. In fact, you might as well fold the GetDWARFParser call into the if condition (`if (DWARFASTParser *parser = ...) parser->...`) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70646/new/ https://reviews.llvm.org/D70646 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
