On Wed, 5 Feb 2020 at 15:26, Stella Stamenova via lldb-commits < lldb-commits@lists.llvm.org> wrote:
> Does this fix the Windows failures that were reported this morning as well? > > I doubt that. In fact, I'm pretty sure it does not even fix the asan failure, but I cannot currently prove that because the build is broken in a couple of other ways too. As Fred pointed out already, you'll need to ensure that the temporary std::string does not get destroyed. Also btw, string.c_str() will never be null, so there's no point in checking that.
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
