xiaobai marked an inline comment as done. xiaobai added a comment. I uploaded this patch primarily to get some feedback on possible alternatives because I'm not happy creating a dependency from `Core` to `Target` here. Suggestions welcome!
================ Comment at: lldb/source/Core/Mangled.cpp:12 #include "lldb/Core/RichManglingContext.h" +#include "lldb/Target/Language.h" #include "lldb/Utility/ConstString.h" ---------------- Not happy about introducing this dependency. Maybe I can remove the `GuessLanguage` method from Mangled and add one to `Language`... something like `Language::GuessMangledSymbolLanguage(Mangled mangled)`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74187/new/ https://reviews.llvm.org/D74187 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
