labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.

All of this code you're adding to Process.cpp is extremely specific to one 
platform's notion of "crash info". This should be factored out so that 
macos-specific details live inside some macos class. (In the current setup, 
it's probably easiest to put it in PlatformDarwin, or some subclass thereof).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74657/new/

https://reviews.llvm.org/D74657



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to