jarin added inline comments.
================ Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:465 + response.PutChar(','); + response.Printf("%" PRIx32, *reg_num); + } ---------------- I think this is not correct: target.xml expects this to be [decimal](https://github.com/llvm-mirror/lldb/blob/d01083a850f577b85501a0902b52fd0930de72c7/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp#L4417). (This is different from qRegisterInfo, which expects [hex](https://github.com/llvm-mirror/lldb/blob/d01083a850f577b85501a0902b52fd0930de72c7/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp#L579).) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74217/new/ https://reviews.llvm.org/D74217 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits