teemperor added a comment. Actually this LGTM (Jonas already caught the thing I wanted to complain about) but the commit message needs some improvements:
- The title should contain "[NFC]" (which is short for "No functional change" and just means that you didn't change any functionality here. Makes it easier for people looking for bugs). - Put a "[lldb]" in front of the title to show that this is just an LLDB commit. - Maybe a more descriptive title between those two tags such as "Minor code cleanup in Editline.cpp". It should be clear from the title what this commit is doing. I'll do that here but in the next commit you are on your own for making a good title :). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75294/new/ https://reviews.llvm.org/D75294 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
