wallace added a comment.

Regarding implementation:

The target.inherit-env setting is only effectively used by CommandObjectProcess 
when launching the target from the command line. lldb-vscode is not following 
the same codepath and not using that property.

What about exposing the Platform's environment in the API and merging 
SBPlatform->GetEnvironment() with the launch.json's environment if 
inheritEnvironment is True? That would be very similar to what is doing 
CommandObjectProcess

---------

If the user creates the target on their own using custom launchCommands, I 
imagine these commands would go through CommandObjectProcess, and if 
target.inherit-env is also set to true, then this would work also for remote 
cases.

Is that right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74636/new/

https://reviews.llvm.org/D74636



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to