friss added a comment. In D76470#1933062 <https://reviews.llvm.org/D76470#1933062>, @labath wrote:
> I think this is a good change, and is in line with what we have discussed > previously. I have just one question about the exact variable interactions > here. > > Since the raison d'être of the new setting is to be able to "un-inherit" a > particular environment variable, I'm wondering if it should only take effect > if `inherit-env` is true (as otherwise you can achieve the same effect by > deleting stuff from env-vars)? So instead of the current flow, the sequence > would be: I find the logic easier to explain if `unset-env-vars` applies generally. I don't see a reason other the the host environment to use it, but I also don't see the harm in letting it override `env-vars`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76470/new/ https://reviews.llvm.org/D76470 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
