vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land.
LGTM with some added test coverage. Jim? ================ Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/unique_ptr/main.cpp:9 + std::unique_ptr<int> up_int = std::make_unique<int>(10); + std::unique_ptr<std::string> up_str = std::make_unique<std::string>("hello"); + ---------------- Could you add test coverage for '&' and '&&', like ``` const std::unique_ptr<std::string> &up_str_ref = up_str; std::unique_ptr<int> &&up_int_rvref = std::move(up_int); ``` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76476/new/ https://reviews.llvm.org/D76476 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits