aleksandr.urakov added a comment.

Hello! But does the format of an exception directory for aarch64 differ 
completely from x86-64 one? Can we somehow adopt the existing parser to support 
it? If we can, I think that this check looks good (we encapsulate the 
difference inside `PECallFrameInfo`). Or may be it is worth to make a different 
parser for aarch64? Then I think the check would look better in 
`ObjectFilePECOFF::CreateEHCallFrameInfo` (and then we will choose a right 
exception directory parser depending on an architecture). What do you think on 
this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77000/new/

https://reviews.llvm.org/D77000



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to