labath added a comment. Sounds fairly noncontroversial. I don't think we have too many of these objects floating around, but if it turns out we do, we could switch to a SmallVector to optimize for the common case of smaller registers.
================ Comment at: lldb/include/lldb/Utility/RegisterValue.h:264 // register for any supported target. - uint8_t length; + uint32_t length; lldb::ByteOrder byte_order; ---------------- how about we stick to uint16_t here ? ================ Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2051 // Parse out the value. - uint8_t reg_bytes[32]; // big enough to support up to 256 bit ymmN register + uint8_t reg_bytes[256]; // big enough to support up to 256 byte AArch64 SVE + // registers ---------------- danielkiss wrote: > Could we use the kMaxRegisterByteSize here? An excellent idea. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77044/new/ https://reviews.llvm.org/D77044 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits