jankratochvil marked 2 inline comments as done. jankratochvil added inline comments.
================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2951 + type_sp = resolved_type->shared_from_this(); + break; } ---------------- aprantl wrote: > I think I'd prefer a return over a break, (iff they are equivalent!). Wrote above - This `break` cannot be changed to `return` as in D77327 it will become a callback lambda. ================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2949 + type_sp = resolved_type->shared_from_this(); + break; } ---------------- This `break` cannot be changed to `return` as in D77327 it will become a callback lambda. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77326/new/ https://reviews.llvm.org/D77326 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits