jankratochvil added a comment. In D73206#1954668 <https://reviews.llvm.org/D73206#1954668>, @labath wrote:
> Having a iterator/callback based api would allow us to minimize the impact of > that, as it would only need to happen for the entries that are really used. > And /I think/ we could make it interface returns DWARFDies directly, and each > index converts to that using the most direct approach available. When I tried to rebase this patch on top of D77327 <https://reviews.llvm.org/D77327> it looks like: <<<<<<< HEAD = D77327 bool GetObjCMethods(lldb_private::ConstString class_name, llvm::function_ref<bool(DIERef ref)> callback) override; ||||||| aed2fdb1671 size_t GetObjCMethodDIEOffsets(lldb_private::ConstString class_name, DIEArray &method_die_offsets) override; ======= size_t GetObjCMethodDIEOffsets(lldb_private::ConstString class_name, std::vector<lldb::user_id_t> &method_die_offsets) override; >>>>>>> user_id_t So IIUC I should convert it first to: `llvm::function_ref<bool(DWARFDIE die)> callback` Going to try that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73206/new/ https://reviews.llvm.org/D73206 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
