aprantl marked an inline comment as done.
aprantl added inline comments.

================
Comment at: lldb/source/Utility/XcodeSDK.cpp:72
+  llvm::VersionTuple version = ParseSDKVersion(input);
+  return {sdk, version};
+}
----------------
sylvestre.ledru wrote:
> With older version of the libcstdc++ (some Ubuntu LTS), it fails with:
> 
> ```
>  error: chosen constructor is explicit in copy-initialization
>   return {sdk, version};
>          ^~~~~~~~~~~~~~
> /usr/lib/gcc/i686-linux-gnu/5.3.1/../../../../include/c++/5.3.1/tuple:612:19: 
> note: explicit constructor declared here
>         constexpr tuple(_U1&& __a1, _U2&& __a2)
> ```
> 
> @aprantl  Could you please have a look ? 
I have made an attempt in f5be71b4450, but if that doesn't work, I'll need some 
help since I don't really know what works and doesn't work on that particular 
platform.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76471/new/

https://reviews.llvm.org/D76471



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to