labath added a comment. In D77047#1980248 <https://reviews.llvm.org/D77047#1980248>, @omjavaid wrote:
> In D77047#1971454 <https://reviews.llvm.org/D77047#1971454>, @labath wrote: > > > In D77047#1966539 <https://reviews.llvm.org/D77047#1966539>, @omjavaid > > wrote: > > > > > @labath Core file FP register access is not supported on AArch64. I am > > > working on a follow up patch to fix it. This patch only has linux changes > > > so can we get this through? > > > > > > This patch is a bit big and basically untested (an unconditionally skipped > > test hardly counts), so I am looking for ways to split it up and add some > > test coverage. I'm also worried about copying what appear to be chunks of > > linux header files... > > > I also considered licensing issues around copying this chunk but found GDB > also copied this chunk of linux defines into its sources. I think its part of > linux headers with license to freely use these headers in client programs. Do > you know any licensing expert who can give us feedback on this patch? The > only reason we have to include these headers here is that on older sysroots > AArch64 compiler we wont be able to compile this code as they dont have these > headers included so far but newer version do include these headers by default. The situation might be different for gdb since they're both GPL-ish. For licensing questions you could try mailing llvm foundation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77047/new/ https://reviews.llvm.org/D77047 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
