JDevlieghere marked 2 inline comments as done.
JDevlieghere added inline comments.
================
Comment at: lldb/include/lldb/Utility/ReproducerInstrumentation.h:305
if (is_trivially_serializable<T>::value)
- return;
+ return const_cast<T &>(t);
// We need to make a copy as the original object might go out of scope.
----------------
labath wrote:
> What's up with the `const_cast` ? Should this maybe take a `T &t` argument
> and let `T` be deduced as `const U` when needed?
I need to decode the template instantiation error for the details, but we need
to return a non-const T.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77602/new/
https://reviews.llvm.org/D77602
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
