kwk added a comment.

> The only code that is currently after addDecl is changing whether the special 
> members are
>  defaulted/trivial. I'm not sure if this actually fixes anything but it's 
> more correct than what we
>  did before.

But at least you return immediately after calling `addDecl`.

When trying to see what `VerifyDecl(cxx_method_decl)` does, I noticed that I 
don't have a `ClangASTContext.cpp` in my source tree. Even grepping for the 
file in the last 400 revisions didn't show it: `git log --stat -n400 | grep 
ClangASTContext.cpp`. No luck with github as well: 
https://github.com/llvm/llvm-project/search?q=ClangASTContext.cpp&unscoped_q=ClangASTContext.cpp.
 Is that expected?


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72698/new/

https://reviews.llvm.org/D72698



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to