labath accepted this revision. labath added a comment. Yeah, I think this looks good too.
================ Comment at: lldb/source/DataFormatters/StringPrinter.cpp:42-43 + llvm_unreachable("unsupported length"); + memcpy(reinterpret_cast<void *>(m_data), + reinterpret_cast<const void *>(bytes), size); + } ---------------- What's up with all the `reinterpret_cast`ing? `T*` is implicitly convertible to a `void*`... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77843/new/ https://reviews.llvm.org/D77843 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits