labath accepted this revision.
labath added a comment.
Yeah, as I said, I think this is already an improvement, which I am not sure
that could be said of the other version, because of the expected-handling
complexities. LGTM, modulo the overzealous conversion to AppendError.
================
Comment at: lldb/source/Commands/CommandObjectTarget.cpp:417
+ } else {
+ result.AppendErrorWithFormatv(
+ "Core file '{0}' ({1}) was loaded.\n", core_file.GetPath(),
----------------
I guess this should stay as Append**Message**
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78712/new/
https://reviews.llvm.org/D78712
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
