vsk added inline comments.

================
Comment at: lldb/source/Utility/XcodeSDK.cpp:44
+  }
+  static_assert(XcodeSDK::Linux == XcodeSDK::numSDKTypes - 1,
+                "New SDK type was added, update this list!");
----------------
I'd expect -Wcovered-switch to break the build if a new case gets added and 
this list isn't updated. Wdyt of dropping numSDKTypes and using an 
llvm_unreachable here instead?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79603/new/

https://reviews.llvm.org/D79603



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to