shafik added inline comments.

================
Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp:854
 
-  ClangModulesDeclVendor *modules_decl_vendor =
-      m_target->GetClangModulesDeclVendor();
+  auto *persistent_vars = llvm::cast<ClangPersistentVariables>(
+      m_target->GetPersistentExpressionStateForLanguage(lldb::eLanguageTypeC));
----------------
Can we just write a helper method to these two steps in `ClangASTSource` and 
then `ClangExpressionDeclMap` will just get it as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79752/new/

https://reviews.llvm.org/D79752



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to