labath added a comment. In D80543#2055448 <https://reviews.llvm.org/D80543#2055448>, @teemperor wrote:
> In D80543#2054405 <https://reviews.llvm.org/D80543#2054405>, @labath wrote: > > > I am all for this, because makes lldb code more consistent with llvm (llvm > > used to have a LLVM_DELETED_FUNCTION macro, but it was removed as soon as > > c++11 came into being). > > > > But please don't commit this straight away -- let's wait a couple of days > > to give people a chance to comment on things. > > > Wasn't LLVM_DELETED_FUNCTION not just a compatibility thing with certain MSVC > versions that didn't handle `= delete` correctly? Well, it was "compatibility" for the fact that MSVC did not support c++11, added back when c++11 was hot off the press. Before that llvm used `/* DO NOT IMPLEMENT */` comments (that was way before my time, but that's what git history says). > DISALLOW_COPY_AND_ASSIGN seems to be more about preventing copy-pasted > declarations. Yes, that's kinda true. I was probably too harsh on it. I actually do see some appeal in that, but I don't think it's worth diverging from the llvm style because of it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80543/new/ https://reviews.llvm.org/D80543 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
