jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land.
I think "This resolves the SBAddress" is better than "This resolves SBAddress". Other than that LGTM. It would be convenient if you could reuse the _runtime_err_str in the doc strings, but I can't see a way to do that in Python. def Foo(): '''%s'''%(_runtime_err_str) etc doesn't raise an error, and defines the function correctly but help(Foo) doesn't show anything. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80848/new/ https://reviews.llvm.org/D80848 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
