This revision was automatically updated to reflect the committed changes. teemperor marked an inline comment as done. Closed by commit rGfd0ab3b3eb88: [lldb] Pass -fPIC flag even when DYLIB_ONLY is set (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80789/new/ https://reviews.llvm.org/D80789 Files: lldb/packages/Python/lldbsuite/test/make/Makefile.rules Index: lldb/packages/Python/lldbsuite/test/make/Makefile.rules =================================================================== --- lldb/packages/Python/lldbsuite/test/make/Makefile.rules +++ lldb/packages/Python/lldbsuite/test/make/Makefile.rules @@ -657,9 +657,14 @@ $(DYLIB_OBJECTS) : CFLAGS += -DCOMPILING_LLDB_TEST_DLL ifneq "$(OS)" "Windows_NT" +ifeq "$(DYLIB_ONLY)" "" +CFLAGS += -fPIC +CXXFLAGS += -fPIC +else $(DYLIB_OBJECTS) : CFLAGS += -fPIC $(DYLIB_OBJECTS) : CXXFLAGS += -fPIC endif +endif $(DYLIB_FILENAME) : $(DYLIB_OBJECTS) ifeq "$(OS)" "Darwin"
Index: lldb/packages/Python/lldbsuite/test/make/Makefile.rules =================================================================== --- lldb/packages/Python/lldbsuite/test/make/Makefile.rules +++ lldb/packages/Python/lldbsuite/test/make/Makefile.rules @@ -657,9 +657,14 @@ $(DYLIB_OBJECTS) : CFLAGS += -DCOMPILING_LLDB_TEST_DLL ifneq "$(OS)" "Windows_NT" +ifeq "$(DYLIB_ONLY)" "" +CFLAGS += -fPIC +CXXFLAGS += -fPIC +else $(DYLIB_OBJECTS) : CFLAGS += -fPIC $(DYLIB_OBJECTS) : CXXFLAGS += -fPIC endif +endif $(DYLIB_FILENAME) : $(DYLIB_OBJECTS) ifeq "$(OS)" "Darwin"
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
