This revision was automatically updated to reflect the committed changes.
Closed by commit rG798644e0a452: [Scalar] Fix assignment operator for long
long. (authored by werat, committed by labath).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80995/new/
https://reviews.llvm.org/D80995
Files:
lldb/source/Utility/Scalar.cpp
lldb/unittests/Utility/ScalarTest.cpp
Index: lldb/unittests/Utility/ScalarTest.cpp
===================================================================
--- lldb/unittests/Utility/ScalarTest.cpp
+++ lldb/unittests/Utility/ScalarTest.cpp
@@ -188,6 +188,16 @@
ScalarGetValue(std::numeric_limits<unsigned long long>::max()));
}
+TEST(ScalarTest, LongLongAssigmentOperator) {
+ Scalar ull;
+ ull = std::numeric_limits<unsigned long long>::max();
+ EXPECT_EQ(std::numeric_limits<unsigned long long>::max(), ull.ULongLong());
+
+ Scalar sll;
+ sll = std::numeric_limits<signed long long>::max();
+ EXPECT_EQ(std::numeric_limits<signed long long>::max(), sll.SLongLong());
+}
+
TEST(ScalarTest, Division) {
Scalar lhs(5.0);
Scalar rhs(2.0);
Index: lldb/source/Utility/Scalar.cpp
===================================================================
--- lldb/source/Utility/Scalar.cpp
+++ lldb/source/Utility/Scalar.cpp
@@ -331,7 +331,7 @@
Scalar &Scalar::operator=(long long v) {
m_type = e_slonglong;
- m_integer = llvm::APInt(sizeof(long) * 8, v, true);
+ m_integer = llvm::APInt(sizeof(long long) * 8, v, true);
return *this;
}
Index: lldb/unittests/Utility/ScalarTest.cpp
===================================================================
--- lldb/unittests/Utility/ScalarTest.cpp
+++ lldb/unittests/Utility/ScalarTest.cpp
@@ -188,6 +188,16 @@
ScalarGetValue(std::numeric_limits<unsigned long long>::max()));
}
+TEST(ScalarTest, LongLongAssigmentOperator) {
+ Scalar ull;
+ ull = std::numeric_limits<unsigned long long>::max();
+ EXPECT_EQ(std::numeric_limits<unsigned long long>::max(), ull.ULongLong());
+
+ Scalar sll;
+ sll = std::numeric_limits<signed long long>::max();
+ EXPECT_EQ(std::numeric_limits<signed long long>::max(), sll.SLongLong());
+}
+
TEST(ScalarTest, Division) {
Scalar lhs(5.0);
Scalar rhs(2.0);
Index: lldb/source/Utility/Scalar.cpp
===================================================================
--- lldb/source/Utility/Scalar.cpp
+++ lldb/source/Utility/Scalar.cpp
@@ -331,7 +331,7 @@
Scalar &Scalar::operator=(long long v) {
m_type = e_slonglong;
- m_integer = llvm::APInt(sizeof(long) * 8, v, true);
+ m_integer = llvm::APInt(sizeof(long long) * 8, v, true);
return *this;
}
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
