fallkrum marked an inline comment as done.
fallkrum added inline comments.

================
Comment at: lldb/source/Target/Thread.cpp:382
+        if (m_stop_info_sp->IsValid() ||
+            (IsStillAtLastBreakpointHit() &&
+             m_resume_state != eStateSuspended) ||
----------------
fallkrum wrote:
> What is historical need for this check? How is it possible for a breakpoint 
> to stop a thread that was already stopped second time even while stepping in 
> multithreaded programs?
Any thoughts on this? Maybe it is better to get rid of 
IsStillAtLastBreakpointHit at all? In this case there will be no need to check 
wether thread was suspended.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80112/new/

https://reviews.llvm.org/D80112



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to