gedatsu217 added inline comments.

================
Comment at: lldb/source/Core/Debugger.cpp:349
 
+bool Debugger::GetUseAutosuggestion() const {
+  const uint32_t idx = ePropertyShowAutosuggestion;
----------------
teemperor wrote:
> You declared the function, but you don't use it anywhere. You should move all 
> the code you added behind `if (GetShowAutosuggestion())` so that it is only 
> active if the user activated the setting (by doing `settings set 
> show-autosuggestion true`).
Sorry, would you tell me more about it?
I understood that I did not use this function, but I do not know how to 
validate it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81001/new/

https://reviews.llvm.org/D81001



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to